feat: add l1 gas estimation for l2 #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canhtrinh
reviewed
Feb 22, 2024
canhtrinh
reviewed
Feb 22, 2024
canhtrinh
reviewed
Feb 22, 2024
canhtrinh
reviewed
Feb 22, 2024
canhtrinh
reviewed
Feb 28, 2024
canhtrinh
reviewed
Feb 28, 2024
canhtrinh
reviewed
Feb 28, 2024
canhtrinh
reviewed
Feb 29, 2024
canhtrinh
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AXE-3191
This PR included l1 gas estimation when specifying destination L2 chain. The additional param
executeDatawill be required if the destination chain is a L2 chain, otherwise the error will be thrown.Breaking Changes
The
sourceChainTokenSymbolwill not be required anymore. If not specified, the native token of source chain will be used to calculate estimated fee. The following functions are affected:calculateNativeGasFeeestimateGasFeeRationale